Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiles inquirer for Node 4 compat #6640

Merged
merged 1 commit into from Nov 6, 2018

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Nov 6, 2018

Summary

Inquirer dropped support for Node 4. We recently upgraded via #6635, which breaks Node 4 compat.

This PR ensures that inquirer is properly transpiled in the legacy build.

Test plan

CI; ran yarn upgrade-interactive and yarn add lodash@doesnt-exist

@buildsize
Copy link

buildsize bot commented Nov 6, 2018

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.1 MB 1.1 MB 1.48 KB (0%)
yarn-[version].js 4.46 MB 4.46 MB -12 bytes (0%)
yarn-legacy-[version].js 4.63 MB 4.65 MB 17.35 KB (0%)
yarn-v[version].tar.gz 1.11 MB 1.11 MB -612 bytes (0%)
yarn_[version]all.deb 812.61 KB 813.59 KB 1002 bytes (0%)

@arcanis arcanis merged commit 85660f7 into yarnpkg:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant