Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-interactive freezes #6198

Closed
jamiewinder opened this issue Aug 1, 2018 · 16 comments
Closed

upgrade-interactive freezes #6198

jamiewinder opened this issue Aug 1, 2018 · 16 comments
Assignees
Labels

Comments

@jamiewinder
Copy link

I've had this same problem on 1.9.2 and the previous stable version (1.7.0?).

I'm on Node 10.7.0 (also tried 10.6.0) on Windows 10.

If I run yarn upgrade-interactive, select the packages I want to upgrade, then I get the summary printed to the terminal, e.g. if I select react:

? Choose which packages to update. react@16.4.1

... but then it freezes. I can't abort (Ctrl-C) the command and return to the terminal either.

I've tried running this with --verbose to give some more detail for this report, but unfortunately nothing else is printed to the terminal. Is there somewhere else I can look for an error to add to this report?

upgrade, install and all the other commands seem to work. I also doesn't just affect one project. I've also tried uninstalling and reinstalling yarn completely, to no avail.

@ghost ghost assigned rally25rs Aug 1, 2018
@ghost ghost added the triaged label Aug 1, 2018
@Jontem
Copy link

Jontem commented Aug 8, 2018

Same here on Windows 10, node v10.3.0 and yarn 1.7.0.

@jamiewinder
Copy link
Author

Has anyone figured out a workaround to this while it gets sorted? I'm currently running the command to get the list of updatable dependencies then aborting out and doing the updates manually. Time consuming, but it works.

@beeplin
Copy link

beeplin commented Sep 18, 2018

Same here. Windows 10 1709, node 10.10.0, yarn 1.9.4

@chasecaleb
Copy link

I'm on Windows 10 with node 10.3.0 and yarn 1.9.4. I can confirm this behavior is consistently broken across cmd, powershell, and git-bash's mintty.

@Jordi-Carrasco
Copy link

Same here. Windows 10. node 10.7.0, yarn 1.9.4

@danielmoncada
Copy link

also having the same problem.

Windows 10, Yarn 1.9.4, Node 10.10.0

@j-cong
Copy link

j-cong commented Oct 5, 2018

I have this problem too.
Windows 8.1, node 10.6.0, yarn 1.10.1
With both git-bash and cmd

@beeplin
Copy link

beeplin commented Oct 7, 2018

yarn 1.10.1 solves this problem for me. windows 10 1709, node 8.12.0

@jamiewinder
Copy link
Author

It's still the same for me on that version of Yarn unfortunately.

Noticed a duplicate of this issue in #6367.

It would be nice to be able to help with this, but I've no idea where to start. Are there any logs I can enable to help trace the cause? Like I said above, I've tried --verbose mode, but it doesn't give any extra info.

@wornut
Copy link

wornut commented Oct 13, 2018

Same here

env

  • windows 10 build 1803
  • node v10.12.0
  • yarn 1.10.1

@bkniffler
Copy link

Hey there, I've just done npm i -g yarn@1.12.0 and it seems to work.

@s-bauer
Copy link

s-bauer commented Oct 19, 2018

@bkniffler Nope, does not seem to work for me! I tried yarn@1.12.0 and yarn@1.13.0 and both get stuck at the upgrade-interactive command!

@xaviergonz
Copy link

Same here

env
windows 10 build 1803
node v10.12.0
yarn 1.10.1 and yarn 1.12.0

@kziemski
Copy link

same here

env
windows 10 build 1803
node v10.12.0
yarn 1.10.1 and yarn 1.12.0

@heyimalex
Copy link

heyimalex commented Oct 26, 2018

I can reproduce this consistently. Console window just hangs indefinitely after you press enter after your choices are made.

  • windows 10 build 16299.726
  • node v10.11.0
  • yarn HEAD

I couldn't figure it out. Stepping through in the chrome debugger, it freezes right after this line, which seemingly returns successfully but then the debugger just stops working. I'm pretty certain that line isn't the suspect, (and actually it runs fine with the exact same args earlier in the process), but suspending the event loop is where the other bug takes hold.

I ran with --prof and the bottom-up profile looks like this if it's helpful:

   ticks parent  name
  144940   98.9%  "C:/Program Files/nodejs/node.exe"
  144893  100.0%    "C:/Program Files/nodejs/node.exe"
  144408   99.7%      LazyCompile: ~handleWriteReq internal/stream_base_commons.js:12:24
  144408  100.0%        LazyCompile: ~writeGeneric internal/stream_base_commons.js:70:22
  144408  100.0%          LazyCompile: ~Socket._writeGeneric net.js:687:42
  144408  100.0%            LazyCompile: ~Socket._write net.js:724:35

I did find that replacing the answers = await reporter.prompt call here with a hard-coded value (same as the one returned from the call) made everything run just fine, so I suspect the issue lies there (I think in this case the console reporter). It looks like upgrade-interactive is the only place where reporter.prompt is ever called, and that select-options-from-the-list input is pretty fancy.

@rally25rs
Copy link
Contributor

Closing as duplicate of #5949
Let's continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests