Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Is @yarnpkg/esbuild-plugin-pnp still necessary for esbuild? #5580

Closed
evanw opened this issue Jul 15, 2023 · 2 comments
Closed
Labels
documentation This issue or pull request is about the documentation

Comments

@evanw
Copy link

evanw commented Jul 15, 2023

I noticed that Yarn's documentation for PnP implies that the plugin @yarnpkg/esbuild-plugin-pnp is required to use Yarn PnP with esbuild. AFAIK this is no longer the case. Should the website be updated to indicate that esbuild now has native support, similar to what the website says for Webpack? Or is there a scenario where esbuild's support falls short, which is why the plugin is still listed as required in Yarn's documentation?

@merceyz
Copy link
Member

merceyz commented Jul 15, 2023

The documentation should be updated, the source code for the plugin was replaced with a README stating it isn't required anymore.
https://github.com/yarnpkg/berry/tree/506ded5f5f5a89553435940c74f1d857fd685a42/packages/esbuild-plugin-pnp

@merceyz merceyz added the documentation This issue or pull request is about the documentation label Jul 15, 2023
@merceyz
Copy link
Member

merceyz commented Oct 21, 2023

The documentation for Yarn v4 no longer mentions it and the Yarn v3 docs were updated in #4726 but it wasn't backported and published.

I've backported it to the v3 docs so this should be resolved now.

@merceyz merceyz closed this as completed Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request is about the documentation
Projects
None yet
Development

No branches or pull requests

2 participants