Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NYC #534

Closed
thealjey opened this issue Oct 16, 2019 · 4 comments
Closed

[Bug] NYC #534

thealjey opened this issue Oct 16, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@thealjey
Copy link

NYC coverage tool does not work with yarn v2 PnP
according to @coreyfarrell the problem is most likely with yarn itself (idk what that might be)
I do not know what else to do but to link that issue here

istanbuljs/nyc#1204

@thealjey thealjey added the bug Something isn't working label Oct 16, 2019
@arcanis
Copy link
Member

arcanis commented Nov 17, 2019

To keep people that might find this issue in the loop: all problems have been identified and fixed in both Yarn and NYC, and it's been confirmed to work on NYC master. It hasn't been released yet, but hopefully once the 15.x branch will be stable we'll be able to close this issue 🙂

@arcanis
Copy link
Member

arcanis commented Dec 17, 2019

I just merged an E2E test against NYC 15.x, closing this issue 🎉

@arcanis arcanis closed this as completed Dec 17, 2019
@coreyfarrell
Copy link

@arcanis could I convince you to do a test run against git://github.com/coreyfarrell/nyc#process-on-spawn? I'm planning to merge this via istanbuljs/nyc#1243, it makes some updates to the way which nyc performs module preload's. I ran a manual test using yarn pnp locally and it worked fine but additional verification would be great.

@arcanis
Copy link
Member

arcanis commented Dec 17, 2019

Looks fine: https://github.com/yarnpkg/berry/pull/641/checks?check_run_id=352760663 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants