Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typescript-patch cannot resolve type declarations inside workspaces #3780

Closed
1 task
sushruth opened this issue Nov 22, 2021 · 2 comments
Closed
1 task
Labels
bug Something isn't working

Comments

@sushruth
Copy link

sushruth commented Nov 22, 2021

Self-service

  • I'd be willing to implement a fix

Describe the bug

Type declarations do not work in yarn workspaces, even when types are installed both in workspace's package.json and root's package.json. This is true for both tsc and tsserver. See example repo here - https://github.com/sushruth/yarn-workspaces-ts-bug

This is how the error looks -

image

Somehow compile and declaration emit succeeds but the above error is shown.

To reproduce

NA

Environment

`envinfo` breaks on windows 11 (since `wmic` cli is no longer present). Could not collect this information.

Additional context

No response

@sushruth sushruth added the bug Something isn't working label Nov 22, 2021
@sushruth sushruth changed the title [Bug?]: Typescript-patch cannot resolve workspace type declaration modules [Bug]: Typescript-patch cannot resolve workspace type declaration modules Nov 22, 2021
@sushruth sushruth changed the title [Bug]: Typescript-patch cannot resolve workspace type declaration modules [Bug]: Typescript-patch cannot resolve workspace type declarations Nov 22, 2021
@sushruth sushruth changed the title [Bug]: Typescript-patch cannot resolve workspace type declarations [Bug]: Typescript-patch cannot resolve type declarations inside workspaces Nov 22, 2021
@dobernike
Copy link

reproduced with typescript 4.5

@merceyz
Copy link
Member

merceyz commented Nov 22, 2021

Duplicate of #3722

@merceyz merceyz marked this as a duplicate of #3722 Nov 22, 2021
@merceyz merceyz closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants