Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: The vscode pnp integration is completely broken (type info, go to definition, etc) #3745

Closed
1 task
danieltroger opened this issue Nov 18, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@danieltroger
Copy link

danieltroger commented Nov 18, 2021

Self-service

  • I'd be willing to implement a fix

Describe the bug

It is impossible to get yarn pnp to work with the latest vscode and typescript.
Zipfs works but imports aren't typed and go to definition doesn't work.

To reproduce

follow the editor guide on a freshly setup user and you'll see it doesn't work.

Here is a video of me following every step and showing that it doesn't work. Please watch it thoroughly and tell me what I'm doing wrong or fix so that it works:

https://youtu.be/UPdtk7Mi6Ew (it's probably still processing if it's blurry)

Environment

System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 17.0.1 - /private/var/folders/q_/xzl9z_1x2g17_4gvys67mfqw0000gn/T/xfs-c8f67124/node
    Yarn: 3.1.0 - /private/var/folders/q_/xzl9z_1x2g17_4gvys67mfqw0000gn/T/xfs-c8f67124/yarn
    npm: 8.1.0 - /usr/local/bin/npm

Additional context

No response

@danieltroger danieltroger added the bug Something isn't working label Nov 18, 2021
@paul-soporan
Copy link
Member

Duplicate of #3722. The TS PnP patch hasn't been updated to cover TS 4.5 yet, that's why it can't resolve imports.

@danieltroger
Copy link
Author

@paul-soporan Ok. It would be great if you could inform users about it in the guide. I made it easy for you, just click "merge" on #3746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants