Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --help with default command should print top-level help #810

Merged
merged 1 commit into from Mar 3, 2017

Conversation

nexdrew
Copy link
Member

@nexdrew nexdrew commented Mar 2, 2017

Fixes #803, see discussion there.

First wrote the failing test, then included the fix.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, and you are awesome 🎉

has your 7.x testing been going alright so far? turned out to be a bigger reshuffling of logic than I expected.

@nexdrew
Copy link
Member Author

nexdrew commented Mar 3, 2017

@bcoe Haven't done a whole lot of 7.x testing, but what I have done looks good so far.

@nexdrew nexdrew merged commit 9c03fa4 into master Mar 3, 2017
@nexdrew nexdrew deleted the default-command-help branch March 3, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

it's weird that running --help on default command does not show help for all commands
2 participants