Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors were not bubbling appropriately from sub-commands to top-level #802

Merged
merged 4 commits into from Feb 26, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Feb 26, 2017

fixes: #794

@lhecker thanks for the bug report, if you have a second would love for you to test out this fix; we'll have it released to npm cache clear; npm i yargs@next in an hour or so.

@pahdo pahdo merged commit 3544e60 into 7.x Feb 26, 2017
@pahdo pahdo deleted the 794-fix branch February 26, 2017 07:31
@lhecker
Copy link

lhecker commented Feb 26, 2017

@bcoe I fell quite ill yesterday (40°C fever yay) and thus don't really feel like coding right now... 😅
But I'll make sure to test it properly as soon as I'm better again in the coming days. 🙂

@bcoe
Copy link
Member Author

bcoe commented Feb 27, 2017

@lhecker get feeling better 👍

changes are ready for you, as soon as you're ready: npm cache clear; npm i yargs@next.

@lhecker
Copy link

lhecker commented Mar 13, 2017

@bcoe Oh now I completely forgot to comment on here… Sorry. ☹️
It works flawless of course! Thanks for this PR. 🙂

@bcoe
Copy link
Member Author

bcoe commented Mar 13, 2017

@lhecker awesome, thanks for the help testing -- please continue reporting any weird issues you bump into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants