Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extending config files breaks on node 0.10 #797

Merged
merged 1 commit into from Feb 25, 2017
Merged

Conversation

stevezhu
Copy link
Contributor

@stevezhu stevezhu commented Feb 25, 2017

issue from #779

path.isAbsolute() not supported in node 0.10
use path.resolve() instead as mentioned in discussion in issue

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@bcoe bcoe merged commit b5fedbe into 7.x Feb 25, 2017
@bcoe bcoe deleted the config-extends-fix branch February 25, 2017 20:50
@phated
Copy link

phated commented Feb 25, 2017

❤️ ❤️ @stevezhu and @bcoe!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants