Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add en strings for unknown command #2262

Merged
merged 2 commits into from Dec 28, 2022

Conversation

shadowspawn
Copy link
Member

Adds the unknown command strings to the en locale. This has no affect on the output, since they are the same as in the code! The intent is so people updating or creating other locales can see the strings available for localising.

Placing the strings after unknown argument in the same place as in the fr locale from #1560, which looks a good place.

Closes: #2259

@bcoe
Copy link
Member

bcoe commented Nov 21, 2022

@shadowspawn thank you 👏 , I will need to fix up the npm installation before we can merge (looks like 9.x doesn't like Node 12).

Perhaps over holidays this year I'll drop Node 12, and simplify yargs' build.

@bcoe bcoe merged commit 1fd530a into yargs:main Dec 28, 2022
@bcoe
Copy link
Member

bcoe commented Dec 28, 2022

@shadowspawn thanks for the contribution \o/

@shadowspawn shadowspawn deleted the feature/unknown-command-en branch February 25, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing entries in locales for unknown command
2 participants