Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): fix "Not enough non-option arguments" message for the Czech language #2242

Merged
merged 1 commit into from Oct 28, 2022

Conversation

mlc-mlapis
Copy link
Contributor

Removing an extra comma at the end of the line.

Removing an extra comma at the end of the line.
@mlc-mlapis
Copy link
Contributor Author

It seems that an additional formal step is still required. What is it? Can I help with it?

@mlc-mlapis
Copy link
Contributor Author

It's a very trivial issue (only a typo, in fact) and simple to review. Why it takes so much time to merge?

@xmedeko
Copy link

xmedeko commented Oct 11, 2022

@mlc-mlapis It needs to be approved by some maintainer: review is required by reviewers with write access.

Maybe @bcoe may help, please? The latest 17.6.0 release is unusable.

@mlc-mlapis
Copy link
Contributor Author

@xmedeko Thanks for the help.

@mlc-mlapis
Copy link
Contributor Author

@bcoe @nexdrew @nexdrew @maxrimue @lrlna Can you help, please? The latest 17.6.0 release is unusable.

Copy link
Member

@nexdrew nexdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes the problem. Thanks for the contribution!

@nexdrew nexdrew changed the title Update cs.json fix(lang): fix "Not enough non-option arguments" message for the Czech language Oct 16, 2022
@nexdrew
Copy link
Member

nexdrew commented Oct 16, 2022

Bug introduced in #2220

@nexdrew
Copy link
Member

nexdrew commented Oct 16, 2022

@bcoe I'm not familiar with the tag/release protocol of yargs anymore, otherwise I would squash and merge this to prepare a 17.6.1 patch release.

Can we get a little help here, since this is affecting nx users? Thanks, hoping you're doing well!

@davidslaby
Copy link

davidslaby commented Oct 18, 2022

I join @nexdrew's pleas. As nx user, I'm not able to run some commands. @bcoe or @mleguen could you help to release patch version, please? Thanks in advance!

@jirihybek
Copy link

Since this was not merged yet (a typo, in 25 days, really?) and it's breaking the nx package, I've found the following workaround. It may help someone.

Run node process with env var LANG like this: LANG=en_US npx create-nx-workspace....

@nexdrew
Copy link
Member

nexdrew commented Oct 28, 2022

I'll go ahead and merge it. Will have to figure out how to get a 17.6.1 release published.

Yargs is used by thousands of projects, and is (or at least was) used as a canary-in-the-goldmine package to help verify regressions of Node itself, so releases carry a lot of weight.

Perhaps @bcoe has been able to automate everything via release-please. Will see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants