pkgConf has no effect after the first usage

[fasttime]

yargs v17.5.1

Currently, pkgConf only loads package.json options when it is called for the first time. All other usages are silently ignored. This makes it impossible to reuse the same instance of Yargs when the cwd or the key value changes.

const Yargs = require('yargs/yargs')([]);
const opts1 = Yargs.pkgConf('test', 'a').parse();
const opts2 = Yargs.pkgConf('test', 'b').parse();
const opts3 = Yargs.pkgConf('test2', 'a').parse();
console.log({ opts1, opts2, opts3 }); // opts1, opts2 and opts3 are the same(!)

In the example above, opts2 and opts3 always end up getting the same values as opts1, because only the first usage of pkgConf has an effect.

It would be helpful if those repeated usages would produce an error telling the user that they are doing something wrong, or even better, if using pkgConf multiple times was allowed.

[shadowspawn]

You could make a new yargs instance for every parse.

const Yargs = require('yargs/yargs');
const opts1 = Yargs([]).pkgConf('test', 'a').parse();
const opts2 = Yargs([]).pkgConf('test', 'b').parse();

[Edit: changed "should make" to "could make".]

[shadowspawn]

I misunderstood that Yargs does mostly make .parse() a non-breaking call. I am going to change my earlier "should make a new yargs instance for every parse" to "could...", hide some of my intermediate answers, and take another look at some point!