Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno: Use globalThis instead of window #2186

Open
rracariu opened this issue May 12, 2022 · 1 comment
Open

Deno: Use globalThis instead of window #2186

rracariu opened this issue May 12, 2022 · 1 comment
Labels
bug deno p2

Comments

@rracariu
Copy link

Currently using Yarg in a Deno Worker would not run because there is no window global in Workers.

To make this work on all cases using globalThis would be better, see:

yargs/lib/platform-shims/deno.ts

Line 94 in fcb4d38

nextTick: window.queueMicrotask,

@bcoe
Copy link
Member

bcoe commented May 14, 2022

Thank you for the suggestion 👍 , would happily take a patch.

rivy added a commit to rivy-js/yargs that referenced this issue Jul 27, 2022
@rivy
fix(deno): use 'globalThis' instead of 'window' (yargs#2186)
034319c
rivy added a commit to rivy-js/yargs that referenced this issue Jul 27, 2022
@rivy
fix(deno): use 'globalThis' instead of 'window' (yargs#2186)
08502aa
@rivy rivy mentioned this issue Jul 27, 2022
Merged
bcoe pushed a commit that referenced this issue Aug 3, 2022
@rivy
fix(deno): use 'globalThis' instead of 'window' (#2186) (#2215)
561fc7a
@github-actions github-actions bot mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug deno p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @rracariu