Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): add missing terms to Russian translation #2181

Merged
merged 2 commits into from May 16, 2022
Merged

fix(lang): add missing terms to Russian translation #2181

merged 2 commits into from May 16, 2022

Conversation

edukisto
Copy link
Contributor

@edukisto edukisto commented May 7, 2022

Resolves #2180.

I’ll put my thoughts here so you can correct me.

"Arguments %s and %s are mutually exclusive": "Аргументы %s и %s являются взаимоисключающими",

The translation is verified, see the English (“-p and -v options are mutually exclusive”) and Russian (“параметры -p и -v являются взаимоисключающими”) Ubuntu man pages.

"Positionals:": "Позиционные аргументы:",

There is no proper translation for the word “positionals”. That’s why the translation contains the noun (“Позиционные аргументы” means “Positional arguments”).

"deprecated": "устарела",
"deprecated: %s": "устарела: %s"

The word “устаревшая” (deprecated) is a feminine adjective, because “команда” (command) and “опция” (option) are feminine nouns in Russian. (Is it possible to make a deprecated argument?)

We can use the adjective in most cases. For example, the phrases “Функция помечена как устаревшая” (“The function is marked as deprecated”), “Эта функция — устаревшая” (“This function is deprecated”), and “Это устаревшая функция” (“This is a deprecated function”) are perfectly correct. However, the past tense verb “устарела” seems more natural in the phrase “Эта функция устарела” (“This function has been deprecated”).

@jly36963
Copy link
Contributor

jly36963 commented May 7, 2022

To answer your question -- yes, an argument can be deprecated.

option (deprecated key): http://yargs.js.org/docs/#api-reference-optionskey-opt
deprecateOption: http://yargs.js.org/docs/#deprecateOption

@jly36963
Copy link
Contributor

jly36963 commented May 7, 2022

The additions look great -- thank you 👍

@jly36963 jly36963 requested a review from bcoe May 7, 2022 19:00
@edukisto
Copy link
Contributor Author

edukisto commented May 7, 2022

option (deprecated key)... deprecateOption...

@jly36963, deprecate and deprecated keys don’t affect positional arguments, but deprecateOption() does the trick! Thank you!

Unfortunately, it breaks the translation a bit :) If we describe an option or command, then the feminine adjective [устаревшая] ([deprecated]) is grammatically correct. But if we describe an argument, you have to write [устаревший], because “argument” is a masculine noun in Russian.

I think I should make a tiny change and replace the word “устаревшая” with the gender‐neutral abbreviation “устаревш.”. It’s not an ideal, but common solution in Russian. (The ICU SelectFormat is the ultimate solution for such cases.)

As far as I know, a similar problem occurs in the Ukrainian locale: “аргумент... [застарілий]” (the argument is... [deprecated]) looks great, but “команда/опція... [застарілий]” (the command/option is... [deprecated]) looks really weird. It should be “команда/опція... [застаріла]”.

@jly36963
Copy link
Contributor

jly36963 commented May 7, 2022

@edukisto
Yargs uses the terminology "positional arguments" and "option arguments" in the docs. "positional" and "option" are noun modifiers in that context, so I imagine that "deprecated" could always use the masculine form to have gender agreement with "arguments". Does this make sense? (Would there still be an issue with "command", as it's feminine?)

@edukisto
Copy link
Contributor Author

edukisto commented May 7, 2022

"positional" and "option" are noun modifiers in that context, so I imagine that "deprecated" could always use the masculine form to have gender agreement with "arguments".

Such a convention would work with only adjectives: “Этот [опциональный/позиционный] аргумент — устаревший” (“The [optional/positional] argument is deprecated”). But “options” and “positionals” are nouns both in English and Russian.

Would there still be an issue with "command", as it's feminine?

Unfortunately, yes.

We should use an abbreviation. “устар.” is better than “устаревш.”, because it is widely used in encyclopedias and dictionaries, including Wiktionary.

@jly36963 jly36963 self-assigned this May 11, 2022
@bcoe bcoe changed the title Make the Russian translation complete lang: add missing terms to Russian translation May 15, 2022
@bcoe
Copy link
Member

bcoe commented May 15, 2022

@jly36963 does this sound good to you?

@jly36963
Copy link
Contributor

jly36963 commented May 15, 2022

@bcoe Yeah, I think the PR looks great 👍

@bcoe bcoe changed the title lang: add missing terms to Russian translation fix(lang): add missing terms to Russian translation May 16, 2022
@bcoe bcoe merged commit 1c331f2 into yargs:main May 16, 2022
@edukisto edukisto deleted the 2180-update-the-russian-translation branch May 17, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete Russian translation
3 participants