fix: dont clobber description for multiple option calls #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jly36963
reviewed
May 6, 2022
jly36963
reviewed
May 6, 2022
|
Left one nit; otherwise, it looks great to me 👍 |
|
@lukekarrys looks good to me, mind addressing @jly36963's one nit, and we'll work on merging? |
|
Looks good to me 👍 |
bcoe
approved these changes
Jul 18, 2022
|
@lukekarrys thank you for the contribution, apologies for the terribly slow review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2169
My original patch from #2169 broke some existing tests, due to it being necessary to call
this.describewhen initially setting up an option even if no explicit description is set.So this PR implements this behavior by only calling
this.describeif there is no existing description OR if the new description is a string.I added a test that I confirmed fails on main and passes in this PR.