fix(completion): don't show positional args choices with option choices #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
Mar 21, 2022
| const positionalKeys = | ||
| this.yargs.getGroups()[this.usage.getPositionalGroupName()] || []; | ||
| const offset = Math.max( | ||
| this.indexAfterLastReset, | ||
| this.yargs.getInternalMethods().getContext().commands.length + | ||
| /* name of the script is first param */ 1 | ||
| ); | ||
| const positionalValues = argv._.slice(offset); |
There was a problem hiding this comment.
Removed since this is a redundant slice.
Previously, when both positional arguments and options has choices, during autocompletion we displayed both at the same time.
alan-agius4
force-pushed
the
positional-completions
branch
from
db14a29
to
bab0f79
Compare
This is similar to the code in `completeOptionKey`
alan-agius4
force-pushed
the
positional-completions
branch
from
bab0f79
to
904772c
Compare
bcoe
approved these changes
Mar 23, 2022
|
@alan-agius4 thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when both positional arguments and options has choices, during autocompletion we displayed both at the same time.