added an example using inquirer prompting #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
requested changes
Jan 9, 2022
There was a problem hiding this comment.
Thanks for the contribution @chrisdugne, left a few recommendations.
docs/examples.md
Outdated
| }; | ||
|
|
||
| const argv = yargs(process.argv.splice(2)) | ||
| .command('ask', 'use inquirer to prompt for your name') |
There was a problem hiding this comment.
rather than using a switch statement, you could do this:
.command('ask', 'use inquirer to prompt for your name', () => {}, async () => {
await askName();
}There was a problem hiding this comment.
ok, it's working without the async/await though
.command('ask', 'use inquirer to prompt for your name', () => {}, askName)There was a problem hiding this comment.
the advantage of async await is that you could await the top level yargs.argv and it shouln't return until you've filled in the prompted messages ... neat right?
There was a problem hiding this comment.
actually I've first tested with your suggestion, and it was not working as expected, not sure why;
chrisdugne
added a commit
to uralys/fox
that referenced
this pull request
Jan 13, 2022
bcoe
approved these changes
Jan 13, 2022
|
@chrisdugne thank you for the contribution. |
|
you're welcome, and I thank you for yargs : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking for how to use inquirer with yargs,
and found this issue: #1476
So here is how I use an async command to prompt things with inquirer
cheers