Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: small simplifications #1933

Merged
merged 3 commits into from May 3, 2021
Merged

refactor: small simplifications #1933

merged 3 commits into from May 3, 2021

Conversation

jly36963
Copy link
Contributor

@jly36963 jly36963 commented May 2, 2021

While looking through the repo, I saw a few lines/sections that could be simplified.

This is my first OSS PR, so let me know if there are things I can do better.

I'll be looking through more of the repo, and eventually the issues tab, but if there is anything you want me to focus on, let me know!

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one recommendation for a follow up PR.

In practice I'd tend to make PRs for each distinct thing you're working on, e.g.,

"fixes bug with X", or "refactor if/else to use some/every", but for this small set of changes I'm fine with the PR title.

lib/cjs.ts Outdated Show resolved Hide resolved
@bcoe bcoe merged commit 96516e7 into yargs:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants