Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old entries from files field in `package.json #1677

Merged
merged 1 commit into from Jun 14, 2020
Merged

chore: remove old entries from files field in `package.json #1677

merged 1 commit into from Jun 14, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 14, 2020

Was exploring the package locally and noticed these: I believe the completion scripts have been removed into completion-templates.ts, and am guessing that build use to be where the build output went?

It's good to remove them since makes the package.json a little smaller, but more importantly prevents publishing unneeded files.

fwiw LICENSE & index.js can actually be removed too as npm always included README, CHANGELOG, LICENCE and whatever main points at.

Copy link
Member

@mleguen mleguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shot for the hbs files, however we need the recently introduced build!

lib/**/*.js itself will disappear in a soon to come commit.

package.json Show resolved Hide resolved
Copy link
Member

@mleguen mleguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mleguen mleguen merged commit cb7fbb8 into yargs:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants