Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with deno #1661

Closed
quilicicf opened this issue May 20, 2020 · 3 comments
Closed

Compatibility with deno #1661

quilicicf opened this issue May 20, 2020 · 3 comments

Comments

@quilicicf
Copy link

Hi guys,

Do you have any plans to add compatibility for deno?

The 1.0.0 is out so it's a good time to think about it I guess.

I'd be thrilled to test it!

@bcoe
Copy link
Member

bcoe commented May 20, 2020

I'm not sure what this entails, would happily accept a patch moving us in that direction? I would guess that we need to get the library fully migrated to TypeScript first?

@quilicicf
Copy link
Author

To migrate to deno you need to perform the following actions (this is gathered from documentary research and trying to migrate one of my own npm modules, which lead me here 😆).

  • Migrate imports from CommonJS to ES: ⚠️ this pushes minimum NodeJS requirement for your module to version 13+ (the 12 will be the LTS until Oct 2020 when the LTS will switch to 14)
  • Migrate dependencies (there should be two entry-points for the module, one that uses Deno deps and one that uses node's). For the dependencies, I think the strategy might be:
    • If they're already Deno-compatible, no issue just import them Deno-like
    • Or one can ask the dependency's maintainer to migrate (what I'm doing here XD)
    • Or one can use another Deno dependency with similar features (more risky IMO)
    • Or one can re-implement the dependency (only makes sense for tiny dependencies I guess)

Note: TS is not gonna be an issue because being a superset of JS, any valid JS is valid TS.

@bcoe
Copy link
Member

bcoe commented Aug 5, 2020

closing in favor of #1706

@bcoe bcoe closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants