Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): link to other Yargs documentation #1642

Merged
merged 4 commits into from May 21, 2020

Conversation

roryokane
Copy link
Contributor

The Yargs Docs page at https://yargs.js.org/docs/ is built from api.md (as can be seen in _layouts/docs.html in https://github.com/yargs/yargs.github.io/). This means that when browsing the Yargs website, it looks like the API docs are the only documentation Yargs has. These links make the other documents discoverable.

The Yargs Docs page at https://yargs.js.org/docs/ is built from `api.md` (as can be seen in `_layouts/docs.html` in https://github.com/yargs/yargs.github.io/). This means that when browsing the Yargs website, it looks like the API docs are the only documentation Yargs has. These links make the other documents discoverable.
@bcoe
Copy link
Member

bcoe commented May 4, 2020

@roryokane I like the idea of adding these links 👍 one thought, could we instead look at whether it's possible to link to a whole docs directory on the website?

@roryokane
Copy link
Contributor Author

I agree it’s a good goal for the website to contain all relevant docs instead of the API docs being on the website and other docs being on GitHub.

I don’t feel like working on that now, though. I would have to learn the setup of the yargs.github.io project, learn the relevant parts of Jekyll and Flatdoc, add pages for each Markdown file in docs/, and then write up a root docs page that links to all those pages. I think just having the links in the Markdown file that is the current root of the docs, docs/api.md, is good enough to start with.

@bcoe
Copy link
Member

bcoe commented May 15, 2020

@roryokane we built the yargs site several years ago now, and could probably rethink every decision made today 😄

I'm happy with adding this section in the meantime.

@bcoe bcoe merged commit 77fcc2b into yargs:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants