Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to website repo in contributing docs #1505

Merged
merged 4 commits into from
Jan 2, 2020
Merged

docs: add link to website repo in contributing docs #1505

merged 4 commits into from
Jan 2, 2020

Conversation

glenwinters
Copy link
Contributor

This adds a short note to the contributing docs about how to contribute to the website since I had a hard time finding how to serve the docs locally.

@mleguen
Copy link
Member

mleguen commented Dec 4, 2019

@glenwinters I discovered this repo with your PR :-)

@bcoe Do we consider yargs.org website to still be maintained? I stopped using it as it described an outdated version of yargs, and the docs directory in the yargs repo is enough for me.

@glenwinters
Copy link
Contributor Author

@mleguen Ha! That's funny.

yargs.org is the 3rd and 4th hit on google when you search for yargs and I found the front page example and API docs page helpful, so perhaps it's worth making some updates.

@bcoe
Copy link
Member

bcoe commented Dec 5, 2019

I would rather us link to http://yargs.js.org/, I would love for us to make sure this website is dusted off and up to date, just not something I've had cycles for...

I feel like the build step broke a couple years ago and I haven't dug into it.

@glenwinters
Copy link
Contributor Author

@bcoe Sorry, I meant yargs.js.org, not yargs.org. That was a typo.

In this PR, I'm linking to the github repo since this is in the contributing docs section.

@bcoe
Copy link
Member

bcoe commented Dec 6, 2019

👍 gotcha, I understand your intention now.

@bcoe bcoe merged commit 4bca2d4 into yargs:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants