Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use decamelize from npm instead of vendored copy #1377

Merged
merged 1 commit into from Jul 19, 2019

Conversation

coreyfarrell
Copy link
Contributor

@bcoe yargs-parser already depends on decamelize@1.2.0 (and it's always require()'ed). So this doesn't add anything to the node_modules directory and it avoids loading two copies of decamelize into memory by making yargs and yargs-parser use the same module.

Note that decamelize@3 is available (requires node.js 6). This is not used because it pulls in xregexp for unicode regex support (9.5MB!!). xregexp will be dropped in a future version when node.js 10 is required.

@bcoe bcoe merged commit 015eeb9 into yargs:master Jul 19, 2019
@coreyfarrell coreyfarrell deleted the decamelize branch July 19, 2019 22:32
@bcoe
Copy link
Member

bcoe commented Jul 30, 2019

@coreyfarrell this is also landed in yargs@next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants