Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tolerate null prototype for config objects with extends #1376

Merged
merged 1 commit into from Jul 23, 2019
Merged

fix: tolerate null prototype for config objects with extends #1376

merged 1 commit into from Jul 23, 2019

Conversation

coreyfarrell
Copy link
Contributor

Fixes #1372

@bcoe bcoe changed the title fix: Tolerate null prototype for config objects with extends fix: tolerate null prototype for config objects with extends Jul 23, 2019
@bcoe bcoe merged commit 3d26d11 into yargs:master Jul 23, 2019
@bcoe
Copy link
Member

bcoe commented Jul 23, 2019

@coreyfarrell 👍 thank you.

@coreyfarrell coreyfarrell deleted the null-prototype branch July 23, 2019 23:12
@bcoe
Copy link
Member

bcoe commented Jul 30, 2019

@coreyfarrell @cspotcode please try npm i yargs@next, it should address this bug 👍

This was referenced Nov 25, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using hasOwnProperty breaks for config objects with null prototype
2 participants
@coreyfarrell @bcoe