fix: return deno env object #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
Feb 26, 2022
|
@johanholmerin at a glance patch looks good, but seems to not be working as expected in Deno tests. |
|
@bcoe Should be fixed now |
bcoe
approved these changes
Feb 27, 2022
|
@johanholmerin thank you for the contribution, this should address yargs/yargs#2136 I believe. |
|
Created a PR ^ that will update |
bcoe
added a commit
to yargs/yargs
that referenced
this pull request
Nov 3, 2022
Currently the `yargs` is not usable in Deno with `.env()`. This was fixed in yargs/yargs-parser#432 It was released in yargs-parser v21.0.1 This dependency bump will fix `yargs` for Deno. Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume the environment object should actually be returned
Fixes yargs/yargs#2136