From 70262e303ff64bdc7f4582f05e731e2da7e16016 Mon Sep 17 00:00:00 2001
From: "Benjamin E. Coe" <bencoe@google.com>
Date: Tue, 9 Aug 2022 17:57:29 -0400
Subject: [PATCH] Revert "fix(halt-at-non-option): prevent known args from
 being parsed when "unknown-options-as-args" is enabled (#438)"

This reverts commit c474bc10c3aa0ae864b95e5722730114ef15f573.
---
 lib/yargs-parser.ts   |  2 +-
 test/yargs-parser.cjs | 10 ----------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/lib/yargs-parser.ts b/lib/yargs-parser.ts
index 764ca64e..5f776705 100644
--- a/lib/yargs-parser.ts
+++ b/lib/yargs-parser.ts
@@ -222,7 +222,7 @@ export class YargsParser {
       let value: string
 
       // any unknown option (except for end-of-options, "--")
-      if (arg !== '--' && /^-/.test(arg) && isUnknownOptionAsArg(arg)) {
+      if (arg !== '--' && isUnknownOptionAsArg(arg)) {
         pushPositional(arg)
       // ---, ---=, ----, etc,
       } else if (truncatedArg.match(/^---+(=|$)/)) {
diff --git a/test/yargs-parser.cjs b/test/yargs-parser.cjs
index 492e3b90..97add48c 100644
--- a/test/yargs-parser.cjs
+++ b/test/yargs-parser.cjs
@@ -3008,16 +3008,6 @@ describe('yargs-parser', function () {
           _: ['./file.js', '--foo', '--', 'barbar']
         })
       })
-
-      it('is not influenced by unknown options when "unknown-options-as-args" is true', function () {
-        const parse = parser(
-          ['-v', '--long', 'arg', './file.js', '--foo', '--', 'barbar'],
-          { configuration: { 'halt-at-non-option': true, 'unknown-options-as-args': true }, boolean: ['foo'] }
-        )
-        parse.should.deep.equal({
-          _: ['-v', '--long', 'arg', './file.js', '--foo', '--', 'barbar']
-        })
-      })
     })
 
     describe('unknown-options-as-args = true', function () {