Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unused-class-component-methods: add getChildContext lifecycle method #3136

Merged
merged 1 commit into from Nov 13, 2021

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 12, 2021

fix #3135

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #3136 (154be0a) into master (21e01b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3136   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         119      119           
  Lines        8072     8072           
  Branches     2876     2876           
=======================================
  Hits         7869     7869           
  Misses        203      203           
Impacted Files Coverage Δ
lib/rules/no-unused-class-component-methods.js 97.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e01b6...154be0a. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll also need to add tests covering this.

@yoyo837
Copy link
Contributor Author

yoyo837 commented Nov 12, 2021

Thanks! We'll also need to add tests covering this.

I try to learn to do add it.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb changed the title Update no-unused-class-component-methods.js [Fix] no-unused-class-component-methods: add getChildContext lifecycle method Nov 13, 2021
@ljharb ljharb merged commit a2f8a35 into jsx-eslint:master Nov 13, 2021
@yoyo837 yoyo837 deleted the patch-1 branch November 14, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

react/no-unused-class-comp-methods support getChildContext
3 participants