[Fix] jsx-no-target-blank: improve error messages
#3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show different error messages depending on whether referrer is allowed; clarify about `noreferrer` only being necessary in older browsers. Closes jsx-eslint#3044.
|
Not fully sure about the phrasing of |
ljharb
approved these changes
Sep 30, 2021
ljharb
force-pushed
the
better-jsx-no-target-blank-reporting
branch
from
965634d
to
7844d8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 115 115
Lines 7729 7731 +2
Branches 2764 2766 +2
=======================================
+ Hits 7540 7542 +2
Misses 189 189
Continue to review full report at Codecov.
|
ljharb
changed the title
jsx-no-target-blank reporting and improved docsjsx-no-target-blank: improve error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message is confusing because it complains about links missing
rel="noreferrer"even ifallowReferreris set totrueand sorel="noopener"is enough to satisfy it. I made it report different messages depending onallowReferrervalue and state that even ifrel="noopener"is enough,rel="noreferrer"is preferred as per #3044 (comment). Also clarified the docs forallowReferrerto prevent misunderstandings like #3044.