[New] jsx-max-props-per-line: allow defining both multi and single line prop count
#3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIL0RAK
force-pushed
the
feat/jsx-max-props-per-line-dual-config
branch
from
262a8ae
to
945c610
Compare
ljharb
requested changes
Sep 19, 2021
ljharb
changed the title
jsx-max-props-per-line allow to define both multi and single line prop countjsx-max-props-per-line: allow defining both multi and single line prop count
SIL0RAK
force-pushed
the
feat/jsx-max-props-per-line-dual-config
branch
from
a800446
to
eaf1bd4
Compare
ljharb
force-pushed
the
feat/jsx-max-props-per-line-dual-config
branch
2 times, most recently
from
2d18878
to
83eb226
Compare
ljharb
approved these changes
Sep 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #3078 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 115 115
Lines 7720 7729 +9
Branches 2757 2764 +7
=======================================
+ Hits 7531 7540 +9
Misses 189 189
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You can only define single or multiple line prop count.
Solution
Allow to config rule to check both multiple and single line tags while maintaining backward compatibility.