[Fix] prop-types, propTypes: handle implicit children prop in react's generic types
#3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact's generic types
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 111 111
Lines 7506 7522 +16
Branches 2758 2767 +9
=======================================
+ Hits 7313 7329 +16
Misses 193 193
Continue to review full report at Codecov.
|
ljharb
force-pushed
the
3062-implicit-children-fix
branch
from
9507a97
to
810806e
Compare
This was referenced Aug 31, 2021
ljharb
added a commit
that referenced
this pull request
Sep 5, 2021
ljharb
added a commit
that referenced
this pull request
Sep 5, 2021
ljharb
added a commit
to ljharb/eslint-plugin-react
that referenced
this pull request
Sep 5, 2021
|
this PR introduced a regression : #3524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3062
All react generic type extends from
type PropsWithChildren<P> = P & { children?: ReactNode | undefined };. So whenever a generic type from React is used I've added an optional children prop tothis.declaredPropTypes.https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L824