Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-newline support prevent option #2935

Merged
merged 1 commit into from Mar 23, 2021

Conversation

jsphstls
Copy link
Contributor

Closes: #2793

@lukasgjetting
Copy link

Awesome!

Maybe the rule config should use the terms "always" and "never" instead of prevent (like semi)?

Not sure though, as that might limit future configuration without introducing breaking changes.

@lukasgjetting
Copy link

Duplicate of #2927?

@jsphstls
Copy link
Contributor Author

jsphstls commented Mar 1, 2021

I can rename the options. I did use an object to make it easier to extend. What do you think @ljharb ?

@sladyn98
Copy link

sladyn98 commented Mar 2, 2021

This is great ! Thanks for solving it I was actually finding it quite difficult to find my way around it. I can understand and learn 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New rule: Control empty lines around JSX tags
4 participants