Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test]no-unused-prop-types: add test assigning this.props to a variable #2737

Merged
merged 1 commit into from Aug 2, 2020
Merged

[Test]no-unused-prop-types: add test assigning this.props to a variable #2737

merged 1 commit into from Aug 2, 2020

Conversation

jzabala
Copy link
Contributor

@jzabala jzabala commented Aug 2, 2020

Closes #2177

ljharb
ljharb approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 5a00096 into jsx-eslint:master Aug 2, 2020
@jzabala jzabala deleted the test/no-unused-prop-types branch August 2, 2020 12:35
@gone-skiing gone-skiing mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives for [no-unused-prop-types] when props is assigned to a local variable
2 participants
@jzabala @ljharb