Allow a custom message with forbid props #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage with forbid props Co-authored-by: Mangesh Tamhankar <mangesh@gusto.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
requested changes
Apr 14, 2020
|
@ljharb Any chance you'll have time to take another look at this soon? Thanks! |
ljharb
approved these changes
May 9, 2020
ljharb
force-pushed
the
features/allow-custom-message-with-forbid-props
branch
from
7d74249
to
9861469
Compare
geshwho
added a commit
to Gusto/eslint-config-gusto
that referenced
this pull request
May 13, 2020
The latest version includes an update to forbid-component-props and forbid-dom-props rules to allow for a custom message (jsx-eslint/eslint-plugin-react#2615). Upgrading will allow us to use this feature in Gusto/zenpayroll#59591.
geshwho
added a commit
to Gusto/eslint-config-gusto
that referenced
this pull request
May 14, 2020
* Upgrade eslint-plugin-react to 7.20.0 The latest version includes an update to forbid-component-props and forbid-dom-props rules to allow for a custom message (jsx-eslint/eslint-plugin-react#2615). Upgrading will allow us to use this feature in Gusto/zenpayroll#59591.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team! When considering using the forbid-component-props and forbid-dom-props rules, an early topic of discussion was whether or not it would be possible to provide a custom error message. This gives the user a chance to better explain why the prop is forbidden, and possible offer an alternative, or best practice, etc.
This PR aims to add custom messaging functionality to both rules of these rules. Let me know if such an enhancement is something you would consider adding and I'm happy to make improvements on it and take any suggestions! Thanks!