Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-components support for jsx-props-no-spreading #2534

Merged
merged 1 commit into from Jan 29, 2020
Merged

Sub-components support for jsx-props-no-spreading #2534

merged 1 commit into from Jan 29, 2020

Conversation

jonathanpalma
Copy link
Contributor

closes #2529

ljharb
ljharb requested changes Dec 27, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very difficult to review this with all these unrelated formatting changes.

lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
lib/rules/jsx-props-no-spreading.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the master branch 2 times, most recently from 8e4cdb6 to 3d445a1 Compare January 28, 2020 23:29
@ljharb ljharb force-pushed the master branch 2 times, most recently from 24ff1c7 to f9aee94 Compare January 28, 2020 23:57
@ljharb ljharb merged commit f9aee94 into jsx-eslint:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react/jsx-props-no-spreading doesn't support "sub-components".
2 participants
@jonathanpalma @ljharb