[Fix]: Does not validate for LogicalExpression #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshi-toma
commented
Dec 24, 2019
lib/util/Components.js
Outdated
| const returnsConditionalJSX = strict ? | ||
| (returnsConditionalJSXConsequent && returnsConditionalJSXAlternate) : | ||
| (returnsConditionalJSXConsequent || returnsConditionalJSXAlternate); | ||
| return strict ? |
There was a problem hiding this comment.
I think strict property not used. So, I should probably remove strict property from isReturningJSXOrNull.
toshi-toma
changed the title
ljharb
approved these changes
Dec 26, 2019
ljharb
force-pushed
the
fix-prop-types-with-logicalExpression
branch
2 times, most recently
from
6eab9e1
to
f02e8ae
Compare
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2526.