Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] jsx-curly-brace-presence: allow trailing spaces in literal #2448

Merged

Conversation

doochik
Copy link
Contributor

@doochik doochik commented Oct 5, 2019

jsx-curly-brace-presence with never reports invalid errors in following cases

<Foo>{' space before or after '}</Foo>
<Foo>
  {'space after '}
  <a>link</a>
  {' space before'}
</Foo>

`jsx-curly-brace-presence` with `never` reports invalid errors in following cases

```
<Foo>{' space before or after '}</Foo>
```

```
<Foo>
  {'space after '}
  <a>link</a>
  {' space before'}
</Foo>
```
@doochik doochik force-pushed the jsx-curly-brace-presence_traling-spaces branch from 2ed84e3 to b25c239 Compare October 5, 2019 14:11
@ljharb ljharb force-pushed the jsx-curly-brace-presence_traling-spaces branch from b25c239 to 1436799 Compare October 6, 2019 23:36
@ljharb ljharb merged commit 1436799 into jsx-eslint:master Oct 6, 2019
@doochik doochik deleted the jsx-curly-brace-presence_traling-spaces branch October 7, 2019 09:23
@rpellerin
Copy link

Do you know when this will be published please?

@ThiefMaster
Copy link
Contributor

Yes, please make a release. I also encountered breakage in this JSX snippet where it tried to remove the curly braces (which is hopefully fixed by this PR as well):

                  <>
                    {', '}
                    <Translate>
                      <Param name="count" value={occurrenceCount} /> occurrences
                    </Translate>
                  </>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants