Bug Repro: Unused PropTypes detects flow destructuring #977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I figured I would open a PR instead of an issue to be able to show the two failing test cases.
The first, should pass because notTarget is used. But it fails with
'target' PropType is defined but prop is never used
. It seems like it takes the destructuring as the props instead of theprops: Props
. Note that this is fine if instead of destructuring{ target }
I do a simple argument likeinfos
(added a test case to show).And on the invalid side, I added a similar test case with two props, one unused, but it fails on the wrong prop.
This change is