Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 'apple-touch-icon' and 'mask-icon' being flagged as invalid values #3132

Closed
hyoretsu opened this issue Nov 12, 2021 · 4 comments
Closed
Labels

Comments

@hyoretsu
Copy link

I'm pretty sure it was added recenty, but this should be a bug right? Even MDN which the rule's page tells us to check mentions how iOS doesn't use icon, but instead apple-touch-icon. mask-icon is also used by them on Safari pinned tabs.

@ljharb
Copy link
Member

ljharb commented Nov 12, 2021

Could you provide the exact code being warned, and the exact warning output on the command line?

@hyoretsu
Copy link
Author

hyoretsu commented Nov 12, 2021

<link rel="apple-touch-icon" sizes="60x60" href="apple-touch-icon-60x60.png" />
<link rel="apple-touch-icon" sizes="76x76" href="apple-touch-icon-76x76.png" />
<link rel="apple-touch-icon" sizes="120x120" href="apple-touch-icon-120x120.png" />
<link rel="apple-touch-icon" sizes="152x152" href="apple-touch-icon-152x152.png" />
<link rel="apple-touch-icon" sizes="180x180" href="apple-touch-icon-180x180.png" />
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#fff" />

This being inside next/document's <Html><Head /><Html>

“apple-touch-icon” is never a valid “rel” attribute value. eslint(react/no-invalid-html-attribute)
“mask-icon” is never a valid “rel” attribute value. eslint(react/no-invalid-html-attribute)

@ljharb ljharb closed this as completed in 87fe152 Nov 13, 2021
@ljharb ljharb added the bug label Nov 13, 2021
@gabor-at-reed
Copy link

I've checked this, and the issue still occurs with v7.30.1 for me.

@ljharb
Copy link
Member

ljharb commented Aug 9, 2022

@gabor-at-reed we have passing tests, so if you would file a new issue with a repro repo that’d be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants