jsx-no-target-blank -> hasExternalLink does not handle attr.value of null

[gaz77a]

Scenario

Add the following test to the valid section of test/lib/rules/jsx-no-target-blank.js
{code: '<a href target="_blank"/>'},

Symptoms

The following error occurs
TypeError: Cannot read property 'type' of null

Resolution

Add attr.value && before attr.value.type === 'Literal'

here is the updated function
function hasExternalLink(node, linkAttribute, warnOnSpreadAttributes, spreadAttributeIndex) { const linkIndex = findLastIndex(node.attributes, (attr) => attr.name && attr.name.name === linkAttribute); const foundExternalLink = linkIndex !== -1 && ((attr) => attr.value && attr.value.type === 'Literal' && /^(?:\w+:|\/\/)/.test(attr.value.value))( node.attributes[linkIndex]); return foundExternalLink || (warnOnSpreadAttributes && linkIndex < spreadAttributeIndex); }

[ljharb]

Thanks!

[gaz77a]

my pleasure