Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] jsx-no-undef: ignore namespaces #2986

Merged
merged 1 commit into from May 17, 2021

Conversation

remcohaszing
Copy link
Contributor

JSX namespaces are transpiled into strings, not identifiers.

This can be seen in here for TypeScript.

Babel behaves the same, but it requires a configuration which isn’t supported by their playground.

JSX namespaces are transpiled into strings, not identifiers.
@ljharb ljharb force-pushed the fix-jsx-no-undef-namespace branch from 07bbe02 to 9aa539d Compare May 17, 2021 04:51
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #2986 (9aa539d) into master (f864ac1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage   97.59%   97.59%   -0.01%     
==========================================
  Files         110      110              
  Lines        7269     7268       -1     
  Branches     2651     2651              
==========================================
- Hits         7094     7093       -1     
  Misses        175      175              
Impacted Files Coverage Δ
lib/rules/jsx-no-undef.js 93.47% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f864ac1...9aa539d. Read the comment docs.

@ljharb ljharb merged commit 9aa539d into jsx-eslint:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants