Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-handler-names: properly substitute value into message #2975

Merged
merged 1 commit into from Apr 25, 2021
Merged

[Fix] jsx-handler-names: properly substitute value into message #2975

merged 1 commit into from Apr 25, 2021

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Apr 25, 2021

Currently the output is ESLint: Prop key for handleChange must begin with '{{handlerPropPrefix}'(react/jsx-handler-names)

@G-Rath G-Rath changed the title fix(js-handler-names): properly substitute value into message fix(jsx-handler-names): properly substitute value into message Apr 25, 2021
ljharb
ljharb reviewed Apr 25, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, nice catch! can there be some test changes to cover this?

@G-Rath
Copy link
Contributor Author

G-Rath commented Apr 25, 2021

Yup, looking into that right now :)

@G-Rath
Copy link
Contributor Author

G-Rath commented Apr 25, 2021

@ljharb have added a test - also did a basic rg search on the codebase for any other instances of this, and didn't find any.

ljharb
ljharb approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm an ag man myself. thanks!

@ljharb ljharb changed the title fix(jsx-handler-names): properly substitute value into message [Fix] jsx-handler-names: properly substitute value into message Apr 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021 •
edited

Codecov Report

Merging #2975 (cad79bb) into master (495a4cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2975   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         110      110           
  Lines        7266     7266           
  Branches     2650     2650           
=======================================
  Hits         7092     7092           
  Misses        174      174
Impacted Files Coverage Δ
lib/rules/jsx-handler-names.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495a4cf...cad79bb. Read the comment docs.

@ljharb ljharb merged commit cad79bb into jsx-eslint:master Apr 25, 2021
@frosas frosas mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@G-Rath @codecov-commenter @ljharb