Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] version detection: support recursive processor virtual filename #2965

Merged
merged 2 commits into from May 28, 2021
Merged

[Fix] version detection: support recursive processor virtual filename #2965

merged 2 commits into from May 28, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Apr 13, 2021

continue to work on #2949

According to eslint/eslint#14227 (comment), virtual filename could be recursive, this PR fix this possible issue.

ljharb
ljharb approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're sure there's no chance of an infinite loop here, lgtm

@JounQin
Copy link
Contributor Author

JounQin commented Apr 14, 2021

if we're sure there's no chance of an infinite loop here, lgtm

Sure, that error indicates the filename is a virtual filename and what means a true filename must exist.

@JounQin
Copy link
Contributor Author

JounQin commented May 25, 2021

@ljharb Any luck to merge?

@ljharb ljharb merged commit 880ab8c into jsx-eslint:master May 28, 2021
@JounQin JounQin deleted the fix/recursive_virtual_filename branch May 28, 2021 05:59
@frosas frosas mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JounQin @ljharb