forbid-dom-props: support JSXNamespacedName
#2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rather strange pattern is common in [FBT](https://facebook.github.io/fbt/docs/params) and valid according to [JSX](http://facebook.github.io/jsx/) (see `JSXNamespacedName`). Without this change the rule fails on the following error: ``` TypeError: Cannot read property 'toUpperCase' of undefined ``` See: adeira/universe#2005
This was referenced Apr 6, 2021
|
Related crashes also spotted here AriPerkkio/eslint-remote-tester#29 (comment). |
mrtnzlml
added a commit
to adeira/universe
that referenced
this pull request
Apr 9, 2021
It's been fixed in jsx-eslint/eslint-plugin-react#2961 and upgraded in #2172
kodiakhq bot
pushed a commit
to adeira/universe
that referenced
this pull request
Apr 9, 2021
It's been fixed in jsx-eslint/eslint-plugin-react#2961 and upgraded in #2172
adeira-github-bot
pushed a commit
to adeira/eslint-config-adeira
that referenced
this pull request
Apr 9, 2021
It's been fixed in jsx-eslint/eslint-plugin-react#2961 and upgraded in adeira/universe#2172 adeira-source-id: 4acf0ad103fe31649d3e9c0d406b91fa9592ac0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather strange pattern is common in FBT and valid according to JSX (see
JSXNamespacedName). Without this change the rule fails on the following error:See: adeira/universe#2005