[Fix] boolean-prop-naming: add check for typescript "boolean" type

[vedadeepta]

• Fixes Incorrect documentation for boolean-prop-naming #2892
• Includes test

Overview of change:

Add a check for typescript boolean type without the need to explicitly define react PropTypes.

type Props = {
  enabled: boolean
}
const Hello = (props: Props) => <div />;

Will throw a linting error for the above code.

[ljharb]

(note, the new tests weren't actually running since [].concat wasn't being used; i've fixed that)

[vedadeepta]

(note, the new tests weren't actually running since [].concat wasn't being used; i've fixed that)

that's weird, because it did run locally using this

node node_modules/mocha/bin/_mocha tests/lib/rules/boolean-prop-naming.js

[ljharb]

@vedadeepta the tests completed, but weren't actually running, because parsers.TS() returns an array, and the tests are objects.

[vedadeepta]

This is the output i get when i run the tests without concat on this branch using the command node node_modules/mocha/bin/_mocha tests/lib/rules/boolean-prop-naming.js (I'm using parser.TS() two times separately for the last two invalid tests e.g parser.TS(testObj1), parser.TS(testObj2) instead of parser.TS(testObj1, testObj2)). Should it be something else?

Also i don't think the last test on the master branch for boolean-prop-naming is running at all. Change it to something like this

parsers.TS({
    code: `
    type TestConstType = {
      enabled: boolean
    }
    const HelloNew = (props: TestConstType) => { return <div /> };
    `,
    options: [{
      rule: '^is[A-Z]([A-Za-z0-9]?)+'
    }],
    parser: parsers['@TYPESCRIPT_ESLINT'],
    errors: [{
      message: 'Prop name (enabled) doesn\'t match rule (^is[A-Z]([A-Za-z0-9]?)+)'
    }]
  }, {
    code: `
    type TestFNType = {
      isEnabled: boolean
    }
    const HelloNew = (props: TestFNType) => { return <div /> };
    `,
    options: [{
      rule: '^is[A-Z]([A-Za-z0-9]?)+'
    }],
    parser: parsers['@TYPESCRIPT_ESLINT'],
    errors: [{
      message: 'Prop name (enabled) doesn\'t match rule (^is[A-Z]([A-Za-z0-9]?)+)'
    }]
  })

The last one should fail but it does not. It also shows "61 passing" (+ no failures reported) instead of 62 as in the screenshot above. The last test is completely omitted on master.

I think there is something wrong with parser.TS function. it just returns the first object most probably.

[ljharb]

parsers.TS returns either its first argument (which is meant to be an array), or an array.

I'll make some changes so it's harder to misuse.

[vedadeepta]

Thanks for looking into it.