[Fix] no-unused-prop-types
: apply skipShapeProps
to exact types
#2883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2850.
The option
skipShapeProps
was only applied toPropTypes.shape
, this pr make the option apply toPropTypes.exact
as well.Props usages like
props.a.map({b} => use(b))
are hard to handle. CurrentlyPropTypes.shape
has the same bug under the optionskipShapeProps: false
. People do not complain about it because most people useskipShapeProps: true
.The bug has two parts:
skipShapeProps
should applies toPropTypes.exact
.props.a.map({b} => use(b))
should be handled.This pr only fixes 1.