Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-max-depth: Cannot read property 'length' of undefined #2869

Closed
AriPerkkio opened this issue Dec 7, 2020 · 0 comments
Closed

jsx-max-depth: Cannot read property 'length' of undefined #2869

AriPerkkio opened this issue Dec 7, 2020 · 0 comments
Assignees

Comments

@AriPerkkio
Copy link
Contributor

Hello, jsx-max-depth rule seems to crash in certain cases. This issue was spotted by automated CI run - it is not blocking my development or anything. https://github.com/AriPerkkio/eslint-remote-tester/runs/1506856587?check_suite_focus=true

"eslint-plugin-react": "^7.21.5"
"extends": ["plugin:react/all"]

Minimal repro:

import React from "react";

export function MyComponent() {
  const A = <>{<div />}</>;
  return <div>{A}</div>;
}
Crash reports from real-world examples

Rule: jsx-max-depth

Message: Cannot read property 'length' of undefined
Path: department-of-veterans-affairs/vets-website/src/platform/forms-system/src/js/components/FieldTemplate.jsx
Link

    </>
  );

  if (useFieldsetLegend) {
    return <fieldset className={containerClassNames}>{content}</fieldset>;
  }

  return <div className={containerClassNames}>{content}</div>;
}
Error:
TypeError: Cannot read property 'length' of undefined
Occurred while linting <text>:118
    at isLeaf (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:55:24)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:113:21
    at Array.forEach (<anonymous>)
    at checkDescendant (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:106:24)
    at JSXExpressionContainer (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:144:11)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:283:22)

Rule: jsx-max-depth

Message: Cannot read property 'length' of undefined
Path: sunilshw/ThreatHunter/x-pack/legacy/plugins/telemetry/public/hacks/welcome_banner/opt_in_banner_component.js
Link

      );
    }

    const titleNode = (
      <span tabIndex="0">{title}</span>
    );

    return (
      <EuiCallOut iconType="questionInCircle" title={titleNode}>
        { details }
Error:
TypeError: Cannot read property 'length' of undefined
Occurred while linting <text>:112
    at isLeaf (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:55:24)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:113:21
    at Array.forEach (<anonymous>)
    at checkDescendant (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:106:24)
    at JSXExpressionContainer (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:144:11)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:283:22)

Rule: jsx-max-depth

Message: Cannot read property 'length' of undefined
Path: OpenSRP/web/packages/keycloak-user-management/src/components/UserList/TableActions/index.tsx
Link

      <Link to={`${URL_USER_EDIT}/${record.id}`} key="actions">
        Edit
      </Link>
      <Divider type="vertical" />
      <Dropdown overlay={menu}>
        <Button type="link" style={{ padding: 0, margin: 0 }}>
          <MoreOutlined
            className="more-options"
            style={{ fontSize: '16px', padding: 0, margin: 0 }}
          />
Error:
TypeError: Cannot read property 'length' of undefined
Occurred while linting <text>:76
    at isLeaf (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:55:24)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:113:21
    at Array.forEach (<anonymous>)
    at checkDescendant (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:106:24)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:114:11
    at Array.forEach (<anonymous>)
    at checkDescendant (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:106:24)
    at JSXExpressionContainer (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:144:11)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)

Rule: jsx-max-depth

Message: Cannot read property 'length' of undefined
Path: mattermost/mattermost-plugin-incident-management/webapp/src/components/profile/profile_selector.tsx
Link

    return (
        <Dropdown
            isOpen={isOpen}
            onClose={toggleOpen}
            target={target}
        >
            <ReactSelect
                autoFocus={true}
                backspaceRemovesValue={false}
                components={components}
Error:
TypeError: Cannot read property 'length' of undefined
Occurred while linting <text>:177
    at isLeaf (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:55:24)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:113:21
    at Array.forEach (<anonymous>)
    at checkDescendant (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:106:24)
    at JSXExpressionContainer (/home/runner/work/eslint-remote-tester/eslint-remote-tester/ci/node_modules/eslint-plugin-react/lib/rules/jsx-max-depth.js:144:11)
    at /home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/home/runner/work/eslint-remote-tester/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants