[New] jsx-no-target-blank: add fixer
#2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 21, 2020
ljharb
reviewed
Dec 23, 2020
| errors: defaultErrors | ||
| }, { | ||
| code: '<a target={"_blank"} href={"//example.com"} rel={"noopenernoreferrernoreferrernoreferrernoreferrernoreferrer"}></a>', | ||
| output: '<a target={"_blank"} href={"//example.com"} rel={"noopener noreferrer"}></a>', |
There was a problem hiding this comment.
it's fine to keep it here since the original was both a string and had curly braces
ljharb
changed the title
jsx-no-target-blank: add fixer
ljharb
force-pushed
the
add-fixer-no-target-blank
branch
from
de33e0b
to
907c8e8
Compare
ljharb
approved these changes
Dec 29, 2020
ljharb
force-pushed
the
add-fixer-no-target-blank
branch
from
907c8e8
to
11eaaae
Compare
|
@Nokel81 ok! i think this time i've got it down to 4 failures, not just in older eslint versions: namely, that the fixer is fixing the code in the spread attribute case. If CI ends up showing those same 4 failures, then fixing that would be the last step to landing this. |
|
Please mark the PR as ready for review once either the tests are passing or you're stuck again (hopefully the former :-p ) |
Nokel81
force-pushed
the
add-fixer-no-target-blank
branch
2 times, most recently
from
b914d29
to
26a9307
Compare
|
@ljharb All tests are passing. |
ljharb
approved these changes
Jan 8, 2021
ljharb
force-pushed
the
add-fixer-no-target-blank
branch
from
26a9307
to
4f2d1eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.