[New]: jsx-key: added checkKeyMustBeforeSpread option for new jsx transform
#2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb should be |
ljharb
requested changes
Oct 19, 2020
lib/rules/jsx-key.js
Outdated
Comment on lines
72
to
87
| let keyAttributeIndex = -1; | ||
| let spreadAttributeIndex = -1; | ||
|
|
||
| attributes.forEach((attribute, i) => { | ||
| if (attribute.type === 'JSXSpreadAttribute') { | ||
| spreadAttributeIndex = i; | ||
| } | ||
|
|
||
| if (attribute.type === 'JSXAttribute') { | ||
| if (propName(attribute) === 'key') { | ||
| keyAttributeIndex = i; | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| return spreadAttributeIndex !== -1 && keyAttributeIndex > spreadAttributeIndex; |
There was a problem hiding this comment.
Suggested change
| let keyAttributeIndex = -1; | |
| let spreadAttributeIndex = -1; | |
| attributes.forEach((attribute, i) => { | |
| if (attribute.type === 'JSXSpreadAttribute') { | |
| spreadAttributeIndex = i; | |
| } | |
| if (attribute.type === 'JSXAttribute') { | |
| if (propName(attribute) === 'key') { | |
| keyAttributeIndex = i; | |
| } | |
| } | |
| }); | |
| return spreadAttributeIndex !== -1 && keyAttributeIndex > spreadAttributeIndex; | |
| var hasFoundSpread = false; | |
| return attributes.some((attribute) => { | |
| if (attribute.type === 'JSXSpreadAttribute') { | |
| hasFoundSpread = true; | |
| return false; | |
| } | |
| if (attribute.type !== 'JSXAttribute') { | |
| return false; | |
| } | |
| return !hasFoundSpread || propName(attribute) === 'key'; | |
| }); |
what about this alternative?
There was a problem hiding this comment.
hasFoundSpread && propName(attribute) === 'key' may be clear
There was a problem hiding this comment.
Sure, in that case you'd need to negate the overarching .some.
ljharb
approved these changes
Oct 20, 2020
ljharb
changed the title
jsx-key: added checkKeyMustBeforeSpread option for new jsx transform
ljharb
added
the
hacktoberfest-accepted
This was referenced Mar 10, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2830
related: facebook/react#20031 (comment)