Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] component detection: add componentWrapperFunctions setting #2713

Merged

Conversation

jzabala
Copy link
Contributor

@jzabala jzabala commented Jul 14, 2020

Closes #2268

Closes jsx-eslint#2268.

Co-authored-by: Johnny Zabala <jzabala.s@gmail.com>
Co-authored-by: Landon Schropp <schroppl@gmail.com>
@jzabala jzabala force-pushed the feat/add-component-wrapper-functions-setting branch from ecdbeda to eed1d61 Compare July 14, 2020 00:55
@flut1
Copy link

flut1 commented Jul 17, 2020

I gave this a try in a project that uses mobx observer(). Works great, it finds all my components now 👍

lib/util/Components.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Dec 30, 2020

Please mark this PR as ready for review once it is ready.

@ljharb ljharb marked this pull request as draft December 30, 2020 04:20
@jillesme
Copy link

@jzabala what's the status on this? Seems to work great!

@ljharb
Copy link
Member

ljharb commented Jan 19, 2021

It needs a rebase and a suggestion adopted, then it should be ready.

@ljharb ljharb force-pushed the feat/add-component-wrapper-functions-setting branch from eed1d61 to 495a4cf Compare April 18, 2021 21:20
@ljharb ljharb marked this pull request as ready for review April 18, 2021 21:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@0d999ef). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2713   +/-   ##
=========================================
  Coverage          ?   97.60%           
=========================================
  Files             ?      110           
  Lines             ?     7266           
  Branches          ?     2650           
=========================================
  Hits              ?     7092           
  Misses            ?      174           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/util/Components.js 99.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d999ef...495a4cf. Read the comment docs.

@ljharb ljharb changed the title [New]: add componentWrapperFunctions setting [New] component detection: add componentWrapperFunctions setting Apr 18, 2021
@ljharb ljharb merged commit 495a4cf into jsx-eslint:master Apr 19, 2021
@LandonSchropp
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ESLint cannot find errors connected with react prop-types when using mobX decorators with stateless components
6 participants