Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]jsx-indent: don't check literals not within JSX #2564

Merged
merged 1 commit into from Feb 3, 2020
Merged

[Fix]jsx-indent: don't check literals not within JSX #2564

merged 1 commit into from Feb 3, 2020

Conversation

toshi-toma
Copy link
Contributor

@toshi-toma toshi-toma commented Feb 3, 2020 •
edited

Fixes #2563

@toshi-toma
Copy link
Contributor Author

Anyway, I created PR.
I'll under investigation for other cases.

@toshi-toma toshi-toma mentioned this pull request Feb 3, 2020
Closed
@toshi-toma
Copy link
Contributor Author

toshi-toma commented Feb 3, 2020 •
edited

I corresponded to JSXFragment. 2be9f24

@toshi-toma
Copy link
Contributor Author

I think it's fixed. Please review.🙏

@ljharb
Copy link
Member

ljharb commented Feb 3, 2020

Thanks for the fast fix!

@ljharb ljharb merged commit 8b576be into jsx-eslint:master Feb 3, 2020
@ljharb ljharb linked an issue Feb 3, 2020 that may be closed by this pull request
False positive for jsx-indent in plain JS #2565
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@oculus42 oculus42 oculus42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for jsx-indent in plain JS 7.18.2 regression: react/jsx-indent lots of false positives
3 participants
@toshi-toma @ljharb @oculus42